Skip to content

Fetch poly token from pm registry #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 14, 2018
Merged

Conversation

kostind
Copy link
Contributor

@kostind kostind commented Dec 6, 2018

Please check if the PR fulfills these requirements

  • The commit message follows our Submission guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Instead of manually entering the PolyToken on the deployment of each contract, have them fetch it from the PMRegistry.

Does this PR introduce a breaking change?

  1. Removed _polyAddress parameter from constructors of all modules and module factories.
  2. Removed _polyToken parameter from SecurityTokenRegistry.initialize
  3. Removed SecurityTokenRegistry.updatePolyTokenAddress

Any Other information:

Copy link
Contributor

@maxsam4 maxsam4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update CHANGELOG, please.
Everything else looks good to me.

@kostind
Copy link
Contributor Author

kostind commented Dec 7, 2018

CHANGELOG has been updated.

@adamdossa adamdossa merged commit 7d8728c into dev-3.0.0 Dec 14, 2018
@maxsam4 maxsam4 deleted the fetch-PolyToken-from-PMRegistry branch January 11, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants