Skip to content

Added support for indivisible tokens in capped STO #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 10, 2018

Conversation

maxsam4
Copy link
Contributor

@maxsam4 maxsam4 commented Nov 15, 2018

Please check if the PR fulfills these requirements

  • The commit message follows our Submission guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Makes capped STO compatible with indivisble tokens.

What is the current behavior?

capped STO reverts when buying indivible tokens with uneven amount.

What is the new behavior?

capped STO buys legal amount of indivisible tokens adn refunds remaining funds.

Does this PR introduce a breaking change?

no.

Any Other information:

will update chnagelog once USD Tiered STO PR is merged to avoid conflicts.

@maxsam4 maxsam4 changed the title Capped sto fix Added support for indivisible tokens in capped STO Nov 15, 2018
Copy link
Contributor

@satyamakgec satyamakgec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good.

@pabloruiz55 pabloruiz55 added this to the 2.1.0 milestone Nov 16, 2018
@pabloruiz55 pabloruiz55 merged commit d771ea4 into dev-2.1.0 Dec 10, 2018
@maxsam4 maxsam4 deleted the capped-sto-fix branch January 11, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants