Merged
Conversation
Contributor
|
I'll try it in an hour, looks good. |
Contributor
Author
I am neutral on the issue. On one hand, we get unified command and on the other, an additional dependency. I'll see if I can make our script unified without the need of an additional package. |
Contributor
Author
|
I was able to make a unified script but it needs to be placed in root directory of the repo as path definition are different on windows. I would prefer using the node module or non-unified commands over placing a script in the root of the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run wintest-> Run tests on windowsnpm run wincov-> Run coverage on windows