Open
Conversation
Added a small validator to catch malformed IDs early instead of failing downstream.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| export function validateMarketId(value: string): void { | ||
| if (!MARKET_ID_RE.test(value)) { | ||
| throw new Error('Invalid market id format') | ||
| } |
There was a problem hiding this comment.
Exported validator function is never used
Low Severity
The validateMarketId function is exported but never imported or called anywhere in the codebase. The PR description states it was added to "catch malformed IDs early instead of failing downstream," but no integration with existing code is present. The validator exists in isolation without any consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a small validator to catch malformed IDs early instead of failing downstream.
Note
Introduces a simple utility to validate market IDs.
validateMarketIdinsrc/utils/validateMarketId.tsenforcing/^[a-zA-Z0-9_-]{6,128}$/and throwingErroron invalid inputWritten by Cursor Bugbot for commit b70f1e8. This will update automatically on new commits. Configure here.