Open
Conversation
Introduces a typed error model for CLOB API responses, making error handling more explicit and developer-friendly by mapping backend error codes to a dedicated ClobApiError class.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| return new ClobApiError( | ||
| message, | ||
| code as ClobApiErrorCode, |
There was a problem hiding this comment.
Unrecognized error codes bypass UNKNOWN_ERROR fallback
The mapApiError function only falls back to "UNKNOWN_ERROR" when response?.errorCode is nullish. If the backend returns an error code string that exists but isn't in the ClobApiErrorCode union (e.g., "TIMEOUT" or "NOT_FOUND"), that unrecognized value passes through and is unsafely cast with as ClobApiErrorCode. This violates the type safety promise and could cause exhaustive switch statements on error.code to have unhandled cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a typed error model for CLOB API responses, making error handling more explicit and developer-friendly by mapping backend error codes to a dedicated ClobApiError class.
Note
Introduces a typed error model for CLOB API responses and a utility to map backend payloads to structured errors.
ClobApiErrorCodeunion andClobApiErrorclass withcode,status, anddetailsmapApiError(response, status)to constructClobApiErrorfrom API responsesWritten by Cursor Bugbot for commit ff8adbc. This will update automatically on new commits. Configure here.