Skip to content

[Bug] World from image ignores resolution option #537

@NeumimTo

Description

@NeumimTo
  • [x ] I have checked that I am on the latest version of Terra.
  • [x ] I have searched the github issue tracker for similar issues, including
    closed ones.
  • [x ] I have made sure that this is not a bug with another mod or plugin, and it
    is Terra that is causing the issue.
  • I have checked that this is an issue with Terra and not an issue with the
    pack I am using.
  • [x ] I have attached a copy of the latest.log file
  • [ x] I have filled out and provided all the appropriate information.

Environment

Name Value
Terra Version Terra-bukkit-7.0.0-BETA+c3d26527a-shaded.jar
Platform / Platform Version paper 1.21.10-84
Any External Plugins or Mods no
Terra Packs In Use edit default overworld pack
Terra Addons In Use - biome-provider-extrusion@1.0.0-BETA+3cf11a9ad
    - biome-provider-image@2.0.0-BETA+3cf11a9ad
    - biome-provider-pipeline@2.0.0-BETA+3cf11a9ad
    - biome-provider-single@1.0.0-BETA+3cf11a9ad
    - biome-query-api@1.0.0-BETA+3cf11a9ad
    - chunk-generator-noise-3d@1.2.1-BETA+3cf11a9ad
    - command-addons@1.0.0-BETA+3cf11a9ad
    - command-packs@1.0.0-BETA+3cf11a9ad
    - command-profiler@1.0.0-BETA+3cf11a9ad
    - command-structures@1.0.0-BETA+3cf11a9ad
    - config-biome@1.0.0-BETA+3cf11a9ad
    - config-distributors@1.0.1-BETA+3cf11a9ad
    - config-feature@1.0.0-BETA+3cf11a9ad
    - config-flora@1.0.1-BETA+3cf11a9ad
    - config-locators@1.1.1-BETA+3cf11a9ad
    - config-noise-function@1.2.0-BETA+3cf11a9ad
    - config-number-predicate@1.0.0-BETA+3cf11a9ad
    - config-ore@1.1.1-BETA+3cf11a9ad
    - config-palette@1.0.0-BETA+3cf11a9ad
    - config-structure@1.0.1-BETA+3cf11a9ad
    - generation-stage-feature@1.1.0-BETA+3cf11a9ad
    - generation-stage-structure@1.0.0-BETA+3cf11a9ad
    - language-yaml@1.0.0-BETA+3cf11a9ad
    - library-image@1.1.0-BETA+3cf11a9ad
    - locator-slant-noise-3d@1.0.0-BETA+3cf11a9ad
    - palette-block-shortcut@1.0.0-BETA+3cf11a9ad
    - pipeline-image@1.0.0-BETA+3cf11a9ad
    - structure-block-shortcut@1.0.0-BETA+3cf11a9ad
    - structure-function-check-noise-3d@1.0.1-BETA+3cf11a9ad
    - structure-mutator@0.1.0-BETA+3cf11a9ad
    - structure-sponge-loader@1.0.0-BETA+3cf11a9ad
    - structure-terrascript-loader@1.2.0-BETA+3cf11a9ad
    - terra@1.0.0
    - terra-bukkit@1.0.0
    - terrascript-function-sampler@1.0.0-BETA+3cf11a9ad

|

Issue Description

When using world from image resolution configuration option has no effect

Steps to reproduce

Create a pack that generates world from image and try to change its size by setting resolution

biomes:
  type: EXTRUSION
  extrusions:
    - << biome-distribution/extrusions/add_cave_biomes.yml:extrusions
  provider:
    type: PIPELINE
    resolution: 2
    blend:
      amplitude: 2
      sampler:
        type: OPEN_SIMPLEX_2
        frequency: 0.1
    pipeline:
      source:
        type: IMAGE
        resolution: 2
        color-sampler:
          type: SINGLE_IMAGE # Only Gen a single image rather tiling
          align: CENTER # Makes center of image at 0,0
          image:
            type: BITMAP
            path: biome-distribution/presets/images/world.png
          outside-sampler: # What to use outside the image
            type: COLOR
            color: "#ffffff" # Use white for area outside the image to match ocean color in image
        color-conversion:
          type: CLOSEST # Pick the biome based on the most similar color in the iamge
          match:
            type: MAP
            map:
              "#123456": tropical-rainforest
              "#ffffff": OCEAN
              "#000000": OCEAN
              "#005fc1": ice-cap
              "#3fd2ff": tundra
              "#3fd2ff": boreal-snowy
              "#235844": boreal-cold
              "#d7d6a4": boreal-warm
              "#94d49e": boreal-hot
              "#4ab593": temperate-cold
              "#29db10": temperate-warm
              "#8c5514": temperate-hot
              "#133f0d": tropical-savanna-wet
              "#295514": tropical-monsoon
      stages:
        - << biome-distribution/stages/add_spots.yml:stages
        - << biome-distribution/stages/add_large_spots.yml:stages
        - << biome-distribution/stages/add_coast.yml:stages
        - << biome-distribution/stages/climate/temperature.yml:stages
        - << biome-distribution/stages/climate/precipitation.yml:stages
        - << biome-distribution/stages/climate/elevation.yml:stages
        - << biome-distribution/stages/add_large_spot_coast.yml:stages
        - << biome-distribution/stages/add_island_shelf.yml:stages
        - << biome-distribution/stages/add_islands.yml:stages
        - << biome-distribution/stages/climate/color.yml:stages
        - << biome-distribution/stages/add_travertine_terraces.yml:stages
        - << biome-distribution/stages/set_biomes_in_climates.yml:stages
        - << biome-distribution/stages/add_biome_color_variants.yml:stages

        - type: REPLACE
          from: todo
          to: TEMPERATE_GRASSLAND
          sampler:
            type: CONSTANT

        - type: FRACTAL_EXPAND
          sampler:
            type: WHITE_NOISE
        - type: FRACTAL_EXPAND
          sampler:
            type: WHITE_NOISE
        - type: FRACTAL_EXPAND
          sampler:
            type: WHITE_NOISE
        - type: FRACTAL_EXPAND
          sampler:
            type: WHITE_NOISE
        - type: SMOOTH
          sampler:
            type: WHITE_NOISE
        - type: SMOOTH
          sampler:
            type: WHITE_NOISE

        - << biome-distribution/stages/add_rivers.yml:stages
        - << biome-distribution/stages/add_trenches.yml:stages

Expected behavior

world will be scaled up

Actual behavior

nothing has happened

Full stacktrace

no exception in log

Additional details

https://mclo.gs/lkyHmtz

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: PendingIssue/PR is currently awaiting approval by a moderator.Type: BugSomething isn't working as intended.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions