Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark Mode #33

Merged

Conversation

jonas-lomholdt
Copy link
Contributor

@jonas-lomholdt jonas-lomholdt commented Jun 5, 2024

This is the PR you didn't know you wanted! It adds a new (highly opinionated) dark mode functionality using the prefers-color-scheme CSS media feature. The preference is automagically picked up via the settings in the operating system.

image image image image

@PolygeneLubricants
Copy link
Owner

I love it! Let's run it on Nightly for a little while to experiment, and then I'll merge it.

@PolygeneLubricants PolygeneLubricants changed the base branch from master to nightly June 7, 2024 10:52
@PolygeneLubricants PolygeneLubricants merged commit 342cd0a into PolygeneLubricants:nightly Jun 7, 2024
1 check passed
@PolygeneLubricants
Copy link
Owner

The lights have now been turned off on nightly.justplanningpoker.com (how appropriate!).

image

@jonas-lomholdt
Copy link
Contributor Author

Awesome! I may have removed a bg-light class on the nav header, that I noticed had a ever so slight gray background. On my screen at home I couldn't see the difference from white. I might need to add it back and override that specific class in the dark mode. Other than that the light mode should be unaffected :)

@PolygeneLubricants
Copy link
Owner

I didn't notice it either. In fact, I think it looks better without it. Let's keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants