Clean up code and hopefully not break everything! #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks fine, have you tested it though? |
|
i swear if we merge another untested pr into the loader i will blow a continent off the face of the earth uwu |
Umm, no... xD
UwU!! |
uwu >w< |
|
Why are you closing this? |
|
can someone test this for me? uwu 🥺 |
|
it's getting rewritten:tm: soooooooooo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up the code - although some things may no longer work as intended! I don't understand why reflection was needed to access ForgeVersion - I'm pretty sure it will be loaded from the same ClassLoader anyway.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation