Skip to content

Polyscript config #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Polyscript config #110

wants to merge 15 commits into from

Conversation

joukepouke
Copy link
Collaborator

1/2 of #107

@IExploitableMan
Copy link
Member

Uhh we dont use _ in private fields, cuz @johnklipi doesn't want to...

@joukepouke
Copy link
Collaborator Author

Uhh we dont use _ in private fields, cuz @johnklipi doesn't want to...

oh bruh I will fix now

Copy link
Member

@IExploitableMan IExploitableMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALSO UNDERSCORES!

@IExploitableMan
Copy link
Member

I apologize for the stupid small fixes, I can fix it myself when I come home

@joukepouke
Copy link
Collaborator Author

Added gld config as well

@joukepouke
Copy link
Collaborator Author

Closes #107

{
}
}
public abstract class PolyScriptMod<TConfig, TExposedConfig> : PolyScriptModBase where TConfig : class where TExposedConfig : class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just call it PolyScript? PolyScript is just a part of the mod.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants