Skip to content

Conversation

@lrazovic
Copy link
Member

After the merge of KILTprotocol/kilt-node#516 we can now verify the DID signature. (more info in the linked PR).

This PR address the necessary changes (to the runtime and tests) to use the new version.

@lrazovic lrazovic requested a review from JuaniRios May 24, 2023 09:14
@linear
Copy link

linear bot commented May 24, 2023

PLMC-192 Update the DIP-pallet

  • [Bleeding edge life - don't wait] Wait for the merge: feat: add DID signature verification and replay protection KILTprotocol/kilt-node#516
  • Remove KILT's runtime-common and use the new kilt-dip-support crate
  • Add comments on the pallet-funding to specify that the Origin should be DipOrigin
    • Let's not enforce this Origin at the moment.
  • Maybe we can add a dummy Extrinsic on the sandbox pallet to test this new restricted origin.

@lrazovic lrazovic marked this pull request as ready for review May 24, 2023 09:14
Copy link
Contributor

@JuaniRios JuaniRios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed offline with Leonardo. LGTM

@JuaniRios JuaniRios merged commit c2214e0 into main Jun 13, 2023
@lrazovic lrazovic deleted the feature/plmc-192-update-the-dip-pallet branch July 13, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants