-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue where the SPM package doesn't compile with Xcode 11.4 #368
Conversation
@akmarinov are you sure it's only This PR would resolve: #368 |
Well, Xcode works in mysterious ways, as the ObjC compatibility header doesn't seem to be an issue in my case.
These package dependencies in a test project work without Xcode showing the issue for me, with the I'm not sure what the impact of turning off the compatibility header would be for ObjC projects, but excluding it in the SPM package shouldn't be an issue. |
That's my whole point. :) |
6339698
to
17930de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes an issue.
@DevAndArtist can you approve this pull request? Or who should we ping? |
@tomovicn I'm just a contributor to the framework (I added some changes to the logging stuff in the past), but not part of Polidea so I can't really approve the PR. Personally I consider this framework as dead and will try to get rid of its dependency in our projects. Your best chances right now are to fork the project and merge this PR in your fork and re-route the dependencies. |
It's a shame since it is a very good library. I dropped them a message to see if they still support this project. |
After updating to Xcode 11.4, my project is showing the following issue with RxBluetoothKit:
I've been able to track down the error to the Info.plist file in the Sources folder.
For whatever reason, Xcode 11.4 now doesn't like that there's a file that's not a
.swift
one. (Xcode 11.3.1 still works fine)I've included that file in the excluded section in the package description, which solves the issue.