Skip SNAP student TANF checks for non-students#8763
Draft
anth-volk wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8763 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 11 1 -10
Lines 171 20 -151
==========================================
- Hits 171 20 -151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8762
Summary
defined_for = "is_snap_higher_ed_student"tois_snap_ineligible_student.tanf_personortanfthrough SNAP student ineligibility.Runtime impact
Before this change, a traced single-household calculation for a non-college adult returned
Falseforis_snap_ineligible_studentbut still requestedtanf_persononce. That can pull the broader TANF tree, including county-related work, into households where the SNAP student ineligibility rule cannot apply.After this change,
is_snap_ineligible_studentis only calculated for people whereis_snap_higher_ed_studentis true. The new trace test asserts zerotanf_personandtanfrequests for a non-higher-ed person. Existing behavior for higher-ed students, including the TANF exception, is preserved.Tests
./.venv/bin/python -m pytest policyengine_us/tests/core/test_snap_student_tanf_dependency.py./.venv/bin/python -m policyengine_core.scripts.policyengine_command test policyengine_us/tests/policy/baseline/gov/usda/snap/eligibility/student/is_snap_ineligible_student.yaml -c policyengine_usmake format315 passed, 1 warning; the command wrapper stayed attached after the pass summary, so it was interrupted after the success output.