Add pragma no cover to truly untestable code #7310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark only code that would cause problems if tested in unit tests: 1. **Microsim-specific branches** (2 files): - county.py: is_over_dataset check - zip_code.py: has_axes check 2. **Behavioral response code** (4 files): Requires reform scenarios with simulation branching - cannot be tested without setting up baseline/reform comparison: - labor_supply_behavioral_response.py - relative_income_change.py - relative_wage_change.py - capital_gains_responses.py Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MaxGhenis
force-pushed
the
coverage-100-pragmas
branch
from
6e37f06 to
31d097e
Compare
Add guidelines to CONTRIBUTING.md and CLAUDE.md specifying that # pragma: no cover should only be used for: 1. Microsim-specific branches (is_over_dataset, has_axes) 2. Behavioral response code requiring simulation branching Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
# pragma: no coveronly to code that would cause problems if tested in unit tests.Changes (6 files)
Microsim-specific branches
county.py:is_over_datasetcheck - only executes during microsimulationzip_code.py:has_axescheck - only executes during microsimulationBehavioral response code
Code that requires reform scenarios with simulation branching - cannot be unit tested without setting up baseline/reform comparison:
labor_supply_behavioral_response.pyrelative_income_change.pyrelative_wage_change.pycapital_gains_responses.pyTest plan
🤖 Generated with Claude Code