Use default argument to numpy.select instead of dummy True condition #7240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace patterns where `True` is used as a fallback condition in `select` statements with the `default` parameter. This provides ~10% performance improvement for select operations. Files updated: - count_days_postpartum.py - ccdf_duration_of_care.py - school_meal_tier.py - section_22_income.py - race.py - medicaid_category.py - taxsim_state.py - wic_category.py - fsla_overtime_occupation_exemption_category.py Fixes #1176 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MaxGhenis
force-pushed
the
fix-select-default-arg
branch
from
cf5cd58 to
925d580
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7240 +/- ##
===========================================
- Coverage 100.00% 94.88% -5.12%
===========================================
Files 12 9 -3
Lines 205 176 -29
===========================================
- Hits 205 167 -38
- Misses 0 9 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaxGhenis
added a commit
that referenced
this pull request
Jan 25, 2026
Adds explicit default= keyword argument to select statements across 16 files for better performance and code clarity. This is a continuation of #7240. Files updated: - taxsim_mstat.py (default=1 for SINGLE) - pell_grant_efc.py (default=0) - pell_grant_household_type.py (default=INDEPENDENT_SINGLE) - ccdf_age_group.py (default=SCHOOL_AGE) - ccdf_market_rate.py (default=0) - age_group.py (default=WORKING_AGE) - az_family_tax_credit_eligible.py (default=0) - ia_standard_deduction_indiv.py (default=SINGLE) - ia_amt_indiv.py (default=SINGLE) - il_personal_exemption.py (default=0) - il_personal_exemption_eligibility_status.py (default=BOTH_ELIGIBLE) - mt_capital_gains_tax_applicable_threshold_indiv.py (default=single threshold) - mt_capital_gains_tax_indiv.py (default=single rates) - state_filing_status_if_married_filing_separately_on_same_return.py (default=SINGLE) - wi_standard_deduction.py (default=single phase out) - pr_earned_income_credit.py (default=single threshold) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Jan 25, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace patterns where
Trueis used as a fallback condition inselectstatements with the explicitdefaultparameter. This provides ~10% performance improvement for select operations according to time tests.Before:
After:
Changes
Updated 9 files to use the
defaultparameter:count_days_postpartum.py- postpartum days calculationccdf_duration_of_care.py- childcare duration categorizationschool_meal_tier.py- school meal tier determinationsection_22_income.py- elderly/disabled credit incomerace.py- race categorizationmedicaid_category.py- Medicaid category selectiontaxsim_state.py- TAXSIM state code mappingwic_category.py- WIC demographic categoryfsla_overtime_occupation_exemption_category.py- FSLA overtime exemptionTest plan
Fixes #1176
🤖 Generated with Claude Code