Improve file naming consistency #6281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename generic filenames (credit.py, income.py, etc.) to match variable names - Split income.py into separate files for total_disability_payments and section_22_income - Fix Illinois filename typos and remove space from il_cta_reduced_fare_program.py - Follows one-variable-per-file standard Salvages improvements from old PR PolicyEngine#1276
- Move household-level variables to proper location under household entity - Update expected decile value for single household test (gets decile 10) - Fixes CI test failures
MaxGhenis
force-pushed
the
add-defined-for-and-fix-naming
branch
from
4df54d1 to
0d3ed1d
Compare
policyengine_us/tests/policy/baseline/household/household_income_decile.yaml
Show resolved
Hide resolved
PavelMakarchuk
approved these changes
Jul 23, 2025
Collaborator
PavelMakarchuk
left a comment
PavelMakarchuk
left a comment
There was a problem hiding this comment.
LGTM after test question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves code maintainability by fixing file naming inconsistencies in the codebase. It salvages valuable improvements from the old PR #1276 that are still relevant.
Changes
Renamed generic filenames to match their variable names:
credit.py→prior_year_minimum_tax_credit.pycredit.py→elderly_disabled_credit.pycredit.py→general_business_credit.pySplit multi-variable files to follow one-variable-per-file standard:
income.pyintototal_disability_payments.pyandsection_22_income.pyFixed filename typos and formatting:
if_tanf_non_financial_eligible.py→il_tanf_non_financial_eligible.py(fixed "if" to "il" for Illinois)il _cta_reduced_fare_program.py→il_cta_reduced_fare_eligible.py(removed space and matched variable name)Testing
Context
This PR salvages the file naming improvements from old PR #1276, which had extensive merge conflicts. The original PR also included
selectstatement improvements anddefined_foradditions, but those have already been implemented or are no longer needed.Closes #1176 (partially - the select statement improvements were already done)