Refactor the social_security_tax in the refundable_ctc calculation
#4652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelMakarchuk
requested changes
Jun 19, 2024
policyengine_us/parameters/gov/irs/credits/ctc/refundable/ss_add.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/irs/credits/ctc/refundable/ss_subtract.yaml
Show resolved
Hide resolved
policyengine_us/variables/gov/irs/credits/ctc/refundable/social_security_excess.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/irs/credits/ctc/refundable/social_security_excess.py
Outdated
Show resolved
Hide resolved
PavelMakarchuk
approved these changes
Jun 20, 2024
policyengine_us/parameters/gov/irs/credits/ctc/refundable/ss_subtract.yaml
Show resolved
Hide resolved
MaxGhenis
reviewed
Jun 20, 2024
policyengine_us/variables/gov/irs/credits/ctc/refundable/ctc_social_security_excess.py
Outdated
Show resolved
Hide resolved
MaxGhenis
reviewed
Jul 21, 2024
policyengine_us/variables/gov/irs/credits/ctc/refundable/ctc_social_security_excess.py
Outdated
Show resolved
Hide resolved
vrathi101
changed the title
social_security_excess in the refundable_ctc calculationsocial_security_tax in the refundable_ctc calculation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4652 +/- ##
==========================================
- Coverage 98.98% 98.98% -0.01%
==========================================
Files 2492 2499 +7
Lines 36236 36312 +76
Branches 189 190 +1
==========================================
+ Hits 35867 35942 +75
Misses 339 339
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. |
MaxGhenis
requested changes
Jul 22, 2024
policyengine_us/parameters/gov/irs/credits/ctc/refundable/ss_add.yaml
Outdated
Show resolved
Hide resolved
MaxGhenis
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4612