Skip to content

Conversation

@Shinuing
Copy link
Collaborator

@Shinuing Shinuing commented Apr 3, 2024

Fix #4328

@Shinuing
Copy link
Collaborator Author

Shinuing commented Apr 5, 2024

@PavelMakarchuk when we combined the head and spouse indiv taxable income, it will break the first integration test.
To be specific,

ms_taxable_income_indiv: [21_400, 0, 0] # should be [13_200, 8_200, 0]
ms_income_tax_before_credits_indiv: [800, 0, 0] # should be [390, 158, 0]
ms_files_separately: false #in this case indiv = joint
ms_income_tax: 800

Do we need to separate the combination based on the head/spouse taxable amount (negative or positive)?

@codecov
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (80ed0c2) to head (f2cf995).
Report is 10 commits behind head on master.

❗ Current head f2cf995 differs from pull request most recent head 7e83e8f. Consider uploading reports for the commit 7e83e8f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4329      +/-   ##
==========================================
- Coverage   99.17%   99.17%   -0.01%     
==========================================
  Files        2418     2410       -8     
  Lines       35015    34883     -132     
  Branches      170      163       -7     
==========================================
- Hits        34725    34594     -131     
+ Misses        260      259       -1     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PavelMakarchuk
Copy link
Collaborator

@PavelMakarchuk when we combined the head and spouse indiv taxable income, it will break the first integration test. To be specific,

ms_taxable_income_indiv: [21_400, 0, 0] # should be [13_200, 8_200, 0]
ms_income_tax_before_credits_indiv: [800, 0, 0] # should be [390, 158, 0]
ms_files_separately: false #in this case indiv = joint
ms_income_tax: 800

Do we need to separate the combination based on the head/spouse taxable amount (negative or positive)?

I think, based on the tax form, that we should separate everything until the tax before non refundable credits - after it should all be combined

image

@Shinuing
Copy link
Collaborator Author

Shinuing commented Apr 9, 2024

@PavelMakarchuk

  1. I hard coded for the ms_taxable_income_joint to simplify the code structure. Let me know if that make sense
  2. Still some difference of the ms_income_tax compared to TAXSIM. I've attach the calculation and let me know if we still miss anything.
Screen Shot 2024-04-09 at 1 36 50 PM

@PavelMakarchuk
Copy link
Collaborator

@PavelMakarchuk

  1. I hard coded for the ms_taxable_income_joint to simplify the code structure. Let me know if that make sense
  2. Still some difference of the ms_income_tax compared to TAXSIM. I've attach the calculation and let me know if we still miss anything.
Screen Shot 2024-04-09 at 1 36 50 PM

Is it obvious what TAXSIM is doing different from PE - do we align on the taxable income amounts?

@Shinuing Shinuing requested a review from PavelMakarchuk April 12, 2024 16:26
@martinholmer
Copy link
Collaborator

@PavelMakarchuk, When is PR #4329 going to be merged?

@Shinuing Shinuing requested a review from PavelMakarchuk April 15, 2024 01:30
@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review April 15, 2024 22:15
@MaxGhenis MaxGhenis merged commit 5ca81d8 into PolicyEngine:master Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Mississippi taxable income calculations

4 participants