Add integration tests against Benefits Plus SNAP Calculator (NYS) #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kvanalebeek
commented
Dec 10, 2021
kvanalebeek
commented
- Integration test(s) added if relevant
MaxGhenis
reviewed
Dec 11, 2021
openfisca_us/tests/policy/baseline/usda/snap/integration/bplc_ny.yaml
Outdated
Show resolved
Hide resolved
openfisca_us/tests/policy/baseline/usda/snap/integration/bplc_ny.yaml
Outdated
Show resolved
Hide resolved
openfisca_us/tests/policy/baseline/usda/snap/integration/bplc_ny.yaml
Outdated
Show resolved
Hide resolved
openfisca_us/tests/policy/baseline/usda/snap/integration/bplc_ny.yaml
Outdated
Show resolved
Hide resolved
openfisca_us/tests/policy/baseline/usda/snap/integration/bplc_ny.yaml
Outdated
Show resolved
Hide resolved
openfisca_us/tests/policy/baseline/usda/snap/integration/bplc_ny.yaml
Outdated
Show resolved
Hide resolved
openfisca_us/tests/policy/baseline/usda/snap/integration/bplc_ny.yaml
Outdated
Show resolved
Hide resolved
openfisca_us/tests/policy/baseline/usda/snap/integration/bplc_ny.yaml
Outdated
Show resolved
Hide resolved
MaxGhenis
reviewed
Dec 19, 2021
| region_str: NY_NYC | ||
| output: | ||
| snap_earnings_deduction: 0 # "Deduction on Gross Earned Income" | ||
| snap_standard_deduction: 177*12 # "Standard Deduction based on household size" |
There was a problem hiding this comment.
Please add a space between arithmetic operators and two spaces before # (as was done here already but not elsewhere).
Suggested change
| snap_standard_deduction: 177*12 # "Standard Deduction based on household size" | |
| snap_standard_deduction: 177 * 12 # "Standard Deduction based on household size" |
| snap_net_income: 82.5 # "Monthly Net SNAP Income" | ||
| snap_max_benefit: 250*12 # "Thrifty Food Plan amount for H.H. size" | ||
| snap: 225*12 | ||
| snap: 225 * 12 # "Potential SNAP Allotment" |
| snap_earnings_deduction: 200 # "Deduction on Gross Earned Income" | ||
| snap_standard_deduction: 177*12 # "Standard Deduction based on household size" | ||
| snap_sua: 852*12 # "SUA Level Amount" | ||
| snap_net_income: 82.5 # "Monthly Net SNAP Income" |
There was a problem hiding this comment.
Suggested change
| snap_net_income: 82.5 # "Monthly Net SNAP Income" | |
| snap_net_income: 82.5 * 12 # "Monthly Net SNAP Income" |
| snap_max_benefit: 250*12 # "Thrifty Food Plan amount for H.H. size" | ||
| snap: 250*12 | ||
| snap: 250 * 12 # "Potential SNAP Allotment" | ||
| #reference: |
There was a problem hiding this comment.
Yeah I think this will have to be description: for now, pending openfisca/openfisca-core#1076
MaxGhenis
changed the title
nikhilwoodruff
force-pushed
the
master
branch
2 times, most recently
from
7926ec9 to
d2543dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.