-
Couldn't load subscription status.
- Fork 201
add income to SMI ratio variable #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add income to SMI ratio variable #383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
+ Coverage 95.01% 95.05% +0.04%
==========================================
Files 59 60 +1
Lines 3668 3703 +35
Branches 480 483 +3
==========================================
+ Hits 3485 3520 +35
Misses 158 158
Partials 25 25
Continue to review full report at Codecov.
|
openfisca_us/tests/policy/baseline/hhs/ccdf/income_to_smi_ratio.yaml
Outdated
Show resolved
Hide resolved
openfisca_us/tests/policy/baseline/hhs/ccdf/income_to_smi_ratio.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should get the test passing
Co-authored-by: Max Ghenis <mghenis@gmail.com>
Co-authored-by: Max Ghenis <mghenis@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you resolve the other conversations if they've been addressed too? Then I think we can merge.
openfisca_us/tests/policy/baseline/hhs/ccdf/income_to_smi_ratio.yaml
Outdated
Show resolved
Hide resolved
|
Sorry, now this needs a version bump and changelog entry. It's not showing in the actions because it was recently added, but it would fail the new checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tolaouk - looks good to merge!
No description provided.