Skip to content

Conversation

@tolaouk
Copy link
Contributor

@tolaouk tolaouk commented Dec 9, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #383 (1163609) into master (115959e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   95.01%   95.05%   +0.04%     
==========================================
  Files          59       60       +1     
  Lines        3668     3703      +35     
  Branches      480      483       +3     
==========================================
+ Hits         3485     3520      +35     
  Misses        158      158              
  Partials       25       25              
Impacted Files Coverage Δ
openfisca_us/variables/hhs/tanf.py 100.00% <ø> (ø)
openfisca_us/variables/demographic/household.py 99.51% <100.00%> (+0.01%) ⬆️
openfisca_us/variables/demographic/spm_unit.py 97.05% <100.00%> (ø)
openfisca_us/variables/hhs/ccdf.py 100.00% <100.00%> (ø)
openfisca_us/variables/hhs/hhs_smi.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115959e...1163609. Read the comment docs.

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should get the test passing

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the other conversations if they've been addressed too? Then I think we can merge.

@MaxGhenis
Copy link
Contributor

Sorry, now this needs a version bump and changelog entry. It's not showing in the actions because it was recently added, but it would fail the new checks.

Copy link
Collaborator

@nikhilwoodruff nikhilwoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tolaouk - looks good to merge!

@nikhilwoodruff nikhilwoodruff merged commit e538b1b into PolicyEngine:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants