Adjust the adds function in the hi_subtractions variable

changelog_entry.yaml

@@ -0,0 +1,4 @@
+- bump: patch
+  changes:
+    fixed:
+    - Adjust the adds function in the hi_subtractions variable.

policyengine_us/parameters/gov/states/hi/tax/income/subtractions/subtractions.yaml

@@ -7,8 +7,10 @@ values:
     - us_govt_interest # Line 18
     - student_loan_interest # Line 18
 
+
 metadata:
   unit: list
+  period: year
   label: Hawaii subtractions from federal adjusted gross income
   reference:
     - title: 2022 N-11 Hawaii Resident Income Tax Instructions

policyengine_us/tests/policy/baseline/gov/states/hi/tax/income/subtractions/integration.yaml

@@ -0,0 +1,46 @@
+- name: Test of hi_subtractions variable
+  absolute_error_margin: 0.01
+  period: 2021
+  input:
+    people:
+      person1:
+        age: 62
+        employment_income: 115_010
+        taxable_interest_income: 5_505
+        taxable_private_pension_income: 6_000
+        social_security_retirement: 12_000
+        ssi: 0  # not in TAXSIM35
+        state_supplement: 0  # not in TAXSIM35
+        wic: 0  # not in TAXSIM35
+      person2:
+        age: 62
+        employment_income: 101_010
+        taxable_interest_income: 5_505
+        taxable_private_pension_income: 6_000
+        social_security_retirement: 12_000
+        ssi: 0  # not in TAXSIM35
+        state_supplement: 0  # not in TAXSIM35
+        wic: 0  # not in TAXSIM35
+      person3:
+        age: 11
+        ssi: 0  # not in TAXSIM35
+        state_supplement: 0  # not in TAXSIM35
+        wic: 0  # not in TAXSIM35
+    tax_units:
+      tax_unit:
+        members: [person1, person2, person3]
+        premium_tax_credit: 0  # not in TAXSIM35
+        local_income_tax: 0  # not in TAXSIM35
+        state_sales_tax: 0  # not in TAXSIM35
+    spm_units:
+      spm_unit:
+        members: [person1, person2, person3]
+        snap: 0  # not in TAXSIM35
+        tanf: 0  # not in TAXSIM35
+    households:
+      household:
+        members: [person1, person2, person3]
+        state_fips: 15  # HI
+  output:  # expected results from filling out the form
+    adjusted_gross_income: 259_430
+    hi_subtractions: 32_400

policyengine_us/variables/gov/states/hi/tax/income/hi_subtractions.py

@@ -9,4 +9,4 @@ class hi_subtractions(Variable):
     defined_for = StateCode.HI
     unit = USD
     definition_period = YEAR
-    adds = "gov.states.hi.tax.income.subtractions"
+    adds = "gov.states.hi.tax.income.subtractions.subtractions"