Skip to content

Conversation

@PavelMakarchuk
Copy link
Collaborator

Fixes #3709

@PavelMakarchuk PavelMakarchuk changed the title Fix Idaho permanent building fund tax calculations Use gross_income rather than id_agi in id_income_tax_liable Jan 29, 2024
@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc321b6) 99.05% compared to head (88c2795) 99.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3719      +/-   ##
==========================================
- Coverage   99.05%   99.05%   -0.01%     
==========================================
  Files        2210     2210              
  Lines       32138    32137       -1     
  Branches      168      168              
==========================================
- Hits        31834    31833       -1     
  Misses        266      266              
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, this also moves the id_pbf from tax before refundable credits to after refundable credits.

@MaxGhenis MaxGhenis merged commit 4068371 into master Jan 29, 2024
@MaxGhenis MaxGhenis deleted the PavelMakarchuk/issue3709 branch January 29, 2024 01:04
nikhilwoodruff added a commit that referenced this pull request Jan 29, 2024
…ns (#3698)

* Add changes

* Update with changes

* Format

* Add and inflation-index remaining SPM components (#3706)

* Capture all components of SPM resources in spm_unit_net_income, and uprate some
Fixes #3686

* Fix #3691

* Changelog

* make format

* Uprate some more

* fix housing piece

* Update PolicyEngine US

* CA TANF income disregards are currently monthly but should be aggregated to yearly (#3710)

* Update PolicyEngine US

* Fix Georgia itemized deduction calculation (#3711)

Fixes #3708

* Update PolicyEngine US

* Enable Georgia income tax structure and to the net income tree (#3717)

* Update PolicyEngine US

* Fix Hawaii AGI subtractions calculation (#3720)

Fixes #3715

* Update PolicyEngine US

* Fix Idaho permanent building fund tax calculations (#3719)

Fixes #3709

* Update PolicyEngine US

* Remove duplicate NIIT addition from Louisiana federal tax deduction (#3718)

* Fix Louisiana federal tax deduction formula
Fixes #3714

* changelog

* minor format

* Update PolicyEngine US

* Add 2024 poverty guideline (#3724)

Fixes #3723

* Update PolicyEngine US

* Add filtering in CPS records

Co-authored-by: Max Ghenis <max@policyengine.org>

* Versioning

---------

Co-authored-by: Max Ghenis <mghenis@gmail.com>
Co-authored-by: Github Actions[bot] <MaxGhenis@users.noreply.github.com>
Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
Co-authored-by: Max Ghenis <max@policyengine.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use gross_income rather than id_agi in id_income_tax_liable

2 participants