Skip to content

Medicaid Tests + Income Threshold Formula for California #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Dec 27, 2021
Merged

Medicaid Tests + Income Threshold Formula for California #366

merged 24 commits into from
Dec 27, 2021

Conversation

@CrimsonOHara
Copy link
Contributor

@CrimsonOHara CrimsonOHara commented Dec 4, 2021 •
edited
Loading

  • Label field added
  • Documentation field added
  • Unit field added
  • Default value field added if relevant
  • Variable name follows conventions
  • Unit test(s) added
  • Integration test(s) added if relevant

Added 4 new tests for medicaid, updated the income threshold formula

@MaxGhenis MaxGhenis changed the title Medicaid Tests + Income Threshold Formula Medicaid Tests + Income Threshold Formula for California Dec 4, 2021
@MaxGhenis MaxGhenis marked this pull request as draft December 6, 2021 17:24
MaxGhenis
MaxGhenis reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after these and the title/href for the parameter reference

openfisca_us/variables/hhs/medicaid.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here below looks like duplicated code

openfisca_us/parameters/hhs/medicaid/income_limit.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add newline

@codecov
Copy link

codecov bot commented Dec 7, 2021 •
edited
Loading

Codecov Report

Merging #366 (bf34636) into master (988a73f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   94.47%   94.51%   +0.04%     
==========================================
  Files          58       59       +1     
  Lines        3402     3428      +26     
  Branches      466      469       +3     
==========================================
+ Hits         3214     3240      +26     
  Misses        163      163              
  Partials       25       25
Impacted Files Coverage Δ
openfisca_us/variables/hhs/medicaid.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988a73f...bf34636. Read the comment docs.

@CrimsonOHara CrimsonOHara marked this pull request as ready for review December 27, 2021 03:15
MaxGhenis
MaxGhenis reviewed Dec 27, 2021
View reviewed changes
parikhsachi and others added 5 commits December 27, 2021 16:09
@parikhsachi @MaxGhenis
Update openfisca_us/parameters/hhs/medicaid/income_limit.yaml
4786d0c 
Co-authored-by: Max Ghenis <mghenis@gmail.com>
@parikhsachi @MaxGhenis
Update setup.py
257d44b 
Co-authored-by: Max Ghenis <mghenis@gmail.com>
@parikhsachi @MaxGhenis
Update openfisca_us/variables/hhs/medicaid.py
5eb101c 
Co-authored-by: Max Ghenis <mghenis@gmail.com>
@parikhsachi
version + import statements changed
4d56a06
@parikhsachi
add new line
8600a82
@MaxGhenis MaxGhenis merged commit 7fecba6 into PolicyEngine:master Dec 27, 2021
@CrimsonOHara CrimsonOHara deleted the new-branch branch December 29, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxGhenis MaxGhenis MaxGhenis left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CrimsonOHara @MaxGhenis @parikhsachi