-
Couldn't load subscription status.
- Fork 201
Usda disabled #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usda disabled #353
Conversation
…led (will updated accordingly on usda_elderly branch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test with the formula
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also rename usda_disabled.yaml to disabled.yaml
Co-authored-by: Max Ghenis <mghenis@gmail.com>
Co-authored-by: Max Ghenis <mghenis@gmail.com>
…ed.yaml to disabled.yaml
Co-authored-by: Max Ghenis <mghenis@gmail.com>
Co-authored-by: Nikhil Woodruff <35577657+nikhilwoodruff@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhilwoodruff note that we moved some fields around and included a float, ssdi alongside the bools. The tests indicate that the previous code still works, i.e. any is capturing ssdi>0.
It'd work here because OpenFisca's test runner automatically parses single-person arrays into bools. But since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple final suggestions then we're good to merge
Co-authored-by: Max Ghenis <mghenis@gmail.com>
Add variable and parameters for USDA disabled status