Skip to content

Conversation

@nikhilwoodruff
Copy link
Collaborator

@nikhilwoodruff nikhilwoodruff commented Nov 28, 2021

New variable: Net Investment Income Tax

  • Label field added
  • Documentation field added
  • Unit field added
  • Default value field added if relevant
  • Variable name follows conventions
  • Unit test(s) added
  • Integration test(s) added if relevant

What's changed

Implements the parameters and variable from NetInvIncTax in taxcalc.

@nikhilwoodruff nikhilwoodruff linked an issue Nov 28, 2021 that may be closed by this pull request
@nikhilwoodruff nikhilwoodruff self-assigned this Nov 29, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #343 (b05d4ae) into master (eed9026) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   93.93%   93.95%   +0.01%     
==========================================
  Files          46       46              
  Lines        3117     3126       +9     
  Branches      436      436              
==========================================
+ Hits         2928     2937       +9     
  Misses        165      165              
  Partials       24       24              
Impacted Files Coverage Δ
openfisca_us/variables/irs/outputs.py 97.27% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed9026...b05d4ae. Read the comment docs.

@nikhilwoodruff
Copy link
Collaborator Author

@MaxGhenis I've added some unit tests testing the NIIT value against tax-calc results (and added the script to this PR)

@nikhilwoodruff nikhilwoodruff merged commit a529659 into master Dec 10, 2021
@MaxGhenis MaxGhenis deleted the net-inv-inc-tax branch January 30, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add NetInvIncTax

1 participant