Add GainsTax #342
Merged
Add GainsTax #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 94.67% 94.87% +0.20%
==========================================
Files 59 59
Lines 3510 3652 +142
Branches 473 480 +7
==========================================
+ Hits 3323 3465 +142
Misses 162 162
Partials 25 25
Continue to review full report at Codecov.
|
MaxGhenis
reviewed
Dec 8, 2021
…into gains-tax
…into gains-tax
|
@MaxGhenis seems like at some point between the tests of the AMT PR and the AMT PR merge, something changed in the coverage action. Fixed by adding the |
MaxGhenis
approved these changes
Dec 28, 2021
MaxGhenis
reviewed
Dec 28, 2021
| definition_period = YEAR | ||
|
|
||
| def formula(tax_unit, period, parameters): | ||
| # Negatives cannot offset other income sources |
There was a problem hiding this comment.
Could you add a unit test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the functionality and variables of
GainsTax. This required converting a multi-output formula into (the minimum number of) single-output variables.