Skip to content

Re-enable skipped sparse matrix builder tests after time_period fix #491

@baogorek

Description

@baogorek

Summary

Several tests for the sparse matrix builder are currently skipped with the reason:

"Sparse matrix builder not used in production; test needs rework after time_period fix"

These tests were disabled after a fix that added time_period to calculate() calls to fix cross-state recalculation issues.

Skipped Tests

  1. test_local_area_calibration/test_geo_masking.py - line 133
  2. test_local_area_calibration/test_cross_state.py - line 15
  3. test_local_area_calibration/test_same_state.py - line 10
  4. test_local_area_calibration/test_matrix_national_variation.py - line 277

Context

From the changelog:

Fixed cross-state recalculation in sparse matrix builder by adding time_period to calculate() calls

The sparse matrix builder itself may not be used in production currently, but these tests should be fixed to ensure the code continues to work if needed in the future.

TODO

  • Investigate what changes are needed to make these tests pass with the time_period fix
  • Either fix the tests or remove them if the sparse matrix builder is truly deprecated
  • Document whether sparse matrix builder is still a supported code path

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions