-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Description
Summary
Several tests for the sparse matrix builder are currently skipped with the reason:
"Sparse matrix builder not used in production; test needs rework after time_period fix"
These tests were disabled after a fix that added time_period to calculate() calls to fix cross-state recalculation issues.
Skipped Tests
test_local_area_calibration/test_geo_masking.py- line 133test_local_area_calibration/test_cross_state.py- line 15test_local_area_calibration/test_same_state.py- line 10test_local_area_calibration/test_matrix_national_variation.py- line 277
Context
From the changelog:
Fixed cross-state recalculation in sparse matrix builder by adding time_period to calculate() calls
The sparse matrix builder itself may not be used in production currently, but these tests should be fixed to ensure the code continues to work if needed in the future.
TODO
- Investigate what changes are needed to make these tests pass with the time_period fix
- Either fix the tests or remove them if the sparse matrix builder is truly deprecated
- Document whether sparse matrix builder is still a supported code path
Metadata
Metadata
Assignees
Labels
No labels