Bump policyengine-core to 3.23.0 #1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to policyengine-core 3.23.0 which adds strict enum validation. Invalid enum values will now raise ValueError instead of silently converting to index 0. This tests that all enum values in our test files are valid. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
MaxGhenis
force-pushed
the
bump-core-3.23.0
branch
from
b6c3a22 to
2507941
Compare
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
The lint failure has been fixed. The test failure is a pre-existing issue unrelated to the core bump - the VAT reform impact test expected 18.7 billion but now calculates 22.1 billion. This may be due to updated microdata or parameter changes, but it's not caused by the enum validation changes in policyengine-core 3.23.0. The enum validation is working correctly - no invalid enum values were detected in the UK test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates policyengine-core from >=3.19.3 to >=3.23.0.
Why
policyengine-core 3.23.0 adds strict enum validation - invalid enum values now raise
ValueErrorinstead of silently converting to index 0 (which caused silent data corruption).This PR tests that all enum values in our test files are valid. If CI fails, it means we have invalid enum values that need to be fixed.
Related
🤖 Generated with Claude Code