Extend fiscal year parameter conversion to 2040 #1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fiscal year conversion in convert_to_fiscal_year_parameters() only
covered years 2015-2025 (range(2015, 2026)). This caused policies that
change on April 6 (UK fiscal year start) to not be reflected in annual
simulations for 2026+.
For example, the two-child limit repeal on April 6, 2026 was returning
the pre-repeal value (2) for param("2026") instead of the post-repeal
value (infinity).
This fix extends the range to 2015-2040 to cover long-term projections.
Also adds test coverage for:
- Two-child limit repeal behavior across fiscal years
- Fiscal year boundary behavior
- Year coverage from 2025-2040
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
convert_to_fiscal_year_parameters()function inpolicyengine_uk/utils/parameters.pyusedrange(2015, 2026), which only covered years 2015-2025. This caused policies that change on April 6 (UK fiscal year start) to not be reflected in simulations for 2026+.Example: The two-child limit repeal on April 6, 2026 was returning:
param("2026")→ 2 (WRONG - should be infinity)param("2026-04-30")→ infinity (correct)Solution
Extended the range to
range(2015, 2041)to cover long-term projections through 2040.Test plan
test_fiscal_year_parameters.pywith tests for:make format🤖 Generated with Claude Code