Add postgraduate loan interest rate variable and interest rate tests #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MaxGhenis
force-pushed
the
postgraduate-interest-rate-and-tests
branch
from
2894080 to
2c617c3
Compare
- Add POSTGRADUATE to StudentLoanPlan enum - Create postgraduate_interest_rate variable (RPI + 3% per Regulation 21B) - Add postgraduate_additional_rate parameter (0.03) per Regulation 21B - Remove hardcoded postgraduate.yaml interest rate parameter - Add student_loan_repayment_rate variable (9% for Plans 1/2/4/5, 6% for Postgraduate) - Update student_loan_repayment to use repayment rate variable and postgraduate threshold - Update student_loan_interest_rate to dispatch to postgraduate rate - Add YAML tests for interest rates and repayment rates Fixes #1422 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
MaxGhenis
force-pushed
the
postgraduate-interest-rate-and-tests
branch
from
2c617c3 to
fc04d22
Compare
Update references to cite the consolidated Education (Student Loans) (Repayment) Regulations 2009 at regulation/21B instead of the 2017 Amendment Regulations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
postgraduate_interest_ratevariable (RPI + 3%, same as Plan 2 max)postgraduate.yamlinterest rate parameter (replaced with calculated variable)student_loan_repaymentto handle postgraduate threshold and 6% ratestudent_loan_interest_rateto dispatch to postgraduate rateWhy
Per Commons Library, postgraduate loans have interest at RPI + 3% throughout the loan term - the same formula as Plan 2's maximum rate. This should use the existing
plan_2.additional_rateparameter (0.03) rather than hardcoded values, since they share the same legislative basis and PMR cap.Test plan
Fixes #1422
🤖 Generated with Claude Code