Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parameter adds/subtracts #75

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

nikhilwoodruff
Copy link
Contributor

Fixes #68

@nikhilwoodruff nikhilwoodruff self-assigned this Jan 2, 2023
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 84.24% // Head: 84.11% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (1236b42) compared to base (0aeae3f).
Patch coverage: 5.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   84.24%   84.11%   -0.14%     
==========================================
  Files         184      184              
  Lines        8685     8699      +14     
  Branches      989      991       +2     
==========================================
  Hits         7317     7317              
- Misses       1120     1134      +14     
  Partials      248      248              
Impacted Files Coverage Δ
policyengine_core/simulations/simulation.py 55.80% <0.00%> (-1.84%) ⬇️
policyengine_core/variables/variable.py 84.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nikhilwoodruff nikhilwoodruff merged commit 1e84c6d into master Jan 3, 2023
@nikhilwoodruff nikhilwoodruff deleted the adds-parameters branch January 3, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept parameters in adds and subtracts
1 participant