British Columbia Disability Credit

Fixes #464

policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/additional_amount_base.yaml → policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/base.yaml

@@ -1,21 +1,20 @@
-description: British Columbia provides an additional disability credit to filers by age.
+description: British Columbia provides an additional disability credit of this amount, based on age.
 brackets: 
-  - amount:
+  - threshold:
+      2022-01-01: 0
+    amount:
       2022-01-01: 4_946
       2023-01-01: 5_242
-    threshold:
-      2022-01-01: 0
-  - amount: 
-      2022-01-01: 0
-    threshold:
+  - threshold:
       2022-01-01: 18
+    amount: 
+      2022-01-01: 0
 metadata:
   type: single_amount
   threshold_unit: year
   amount_unit: currency-CAD
   period: year
-  name: bc_additional_disability_credit
-  label: British Columbia additional disability credit
+  label: British Columbia disability credit additional amount base 
   reference:
   - title: B.C. basic personal income tax credits
     href: https://www2.gov.bc.ca/gov/content/taxes/income-taxes/personal/credits/basic

policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/cap.yaml

@@ -5,7 +5,7 @@ values:
 metadata:
   unit: currency-CAD
   period: year
-  label: British Columbia disability credit max amount
+  label: British Columbia disability credit cap
   reference:
   - title: B.C. basic personal income tax credits
     href: https://www2.gov.bc.ca/gov/content/taxes/income-taxes/personal/credits/basic

policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/income_threshold.yaml → policyengine_canada/parameters/gov/provinces/bc/tax/income/credits/disability/additional_amount/childcare_expense_threshold.yaml

@@ -5,7 +5,7 @@ values:
 metadata:
   unit: currency-CAD
   period: year
-  label: British Columbia disability credit income threshold
+  label: British Columbia disability credit additional amount childcare expense threshold
   reference:
   - title: B.C. basic personal income tax credits
     href: https://www2.gov.bc.ca/gov/content/taxes/income-taxes/personal/credits/basic

policyengine_canada/variables/gov/provinces/bc/tax/income/credits/bc_disability_credit/bc_disability_credit_additional_amount.py

@@ -16,10 +16,10 @@ def formula(person, period, parameters):
             "childcare_expenses_claimed_by_another_person", period
         )
         reduced_childcare_expenses = max_(
-            0, childcare_expenses - p.additional_amount.income_threshold
+            0,
+            childcare_expenses
+            - p.additional_amount.childcare_expense_threshold,
         )
         age = person("age", period)
-        additional_amount_base = (
-            p.additional_amount.additional_amount_base.calc(age)
-        )
+        additional_amount_base = p.additional_amount.base.calc(age)
         return max_(0, additional_amount_base - reduced_childcare_expenses)