Skip to content

ADR-0001: populace/axiom seam ownership + spec contradiction fix - #120

Merged
MaxGhenis merged 1 commit into
masterfrom
adr-0001-seam-ownership
Jul 10, 2026
Merged

ADR-0001: populace/axiom seam ownership + spec contradiction fix#120
MaxGhenis merged 1 commit into
masterfrom
adr-0001-seam-ownership

Conversation

@MaxGhenis

@MaxGhenis MaxGhenis commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add accepted ADR 0001 with the issue Integration design: dynamics → Populace panel → full tax-benefit incidence #100 W1/W2/W3 ownership decision and sequencing reproduced faithfully.
  • Retire the specification claim that AIME, PIA, spousal benefits, and family-maximum calculations all run through an existing PolicyEngine-US Social Security implementation.
  • Document the actual boundary: PolicyEngine-US provides the AIME/PIA foundation, this repository carries statute-cited spouse and survivor constants validated against SSA worked examples, and W3 will upstream Axiom/rulespec formulas after frozen-oracle cross-validation.
  • Add a regression test that requires the ADR and prevents the retired claim from returning.

Why

External review issue #106 finding 8 identified a contradiction between the technical specification, the implemented boundary in ss/params.py, and the ownership decision in issue #100.

Testing

  • pytest tests/test_adr_consistency.py -q (2 passed)
  • uvx black -l 79 --check tests/test_adr_consistency.py
  • uvx ruff check tests/test_adr_consistency.py

@MaxGhenis @codex
ADR-0001 seam ownership; fix spec/source contradiction (review #106 f…
f8a8819 
…inding 8)

Co-Authored-By: Codex gpt-5.6-sol <noreply@openai.com>
@vercel

vercel Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
social-security-model Ready Ready Preview, Comment Jul 10, 2026 3:39am

Request Review

@MaxGhenis
MaxGhenis merged commit 796d336 into master Jul 10, 2026
7 checks passed
MaxGhenis added a commit that referenced this pull request Jul 10, 2026
@MaxGhenis @claude
Refresh tier counts after master merge (#114-#117, #116, #120 test ad…
44389a3 
…ditions)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MaxGhenis added a commit that referenced this pull request Jul 10, 2026
@MaxGhenis @codex @claude
Test-tier markers: unit/artifact/integration_psid/reproduction_legacy…
bc20020 
…/oracle_policyengine (#119)

* Test-tier markers via collection-time classification (review #106 finding 9)

Co-Authored-By: Codex gpt-5.6-sol <noreply@openai.com>

* Refresh tier counts after master merge (#114-#117, #116, #120 test additions)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Codex gpt-5.6-sol <noreply@openai.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 10, 2026
Open
Merged

This branch was successfully deployed

1 active deployment
Preview — f8a88197 Deployed Jul 10, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MaxGhenis