Refactor into Python package with TDD #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created givecalc/ package separating calculation logic from UI - Added 33 comprehensive tests with pytest (TDD approach) - Fixed axes aggregation bug (use tax_unit instead of household for 2025) - Updated to 2025 tax calculations - Improved UI: sidebar layout, spinners, input persistence with st.form - Fixed chart y-axis scaling issues - Added Makefile for common tasks (test, run, format) - Added pyproject.toml (modern Python packaging) - Removed deprecated setup.py - Organized all UI components in ui/ directory - Added performance caching for faster calculations - Fixed numpy deprecation warnings 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Run tests on Python 3.10, 3.11, 3.12 - Check code formatting with Black and isort - Use uv for fast dependency installation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add plugin auto-install configuration in .claude/settings.json - Configure auto-install of analysis-tools plugin from PolicyEngine/policyengine-claude - Provides 3 skills for PolicyEngine calculator/analysis workflows Included skills: - policyengine-us-skill: Simulation patterns, situation creation, variable reference - policyengine-analysis-skill: Impact analysis, Streamlit dashboards, Plotly visualizations - policyengine-standards-skill: Code quality, formatting, CI requirements Benefits: - Automated reference documentation for PolicyEngine patterns - Best practices for calculator apps and analysis - Consistent code quality and visualization standards
- Fix pyproject.toml to explicitly include only givecalc package - Update license to SPDX format (MIT) to avoid deprecation warnings - Update Python version support to 3.11-3.13 - Update CI workflow to test Python 3.11, 3.12, 3.13 - Run code formatters (black, isort) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove form wrapper for better UX - inputs update immediately - Reorganize sidebar flow: personal info first, then donation question - Improve donation question: "How much would you like to donate?" - Better radio options: "I have an amount in mind" vs "I have a net income reduction target in mind" - Add tooltip to state selector explaining it's for state tax calculations - Remove dividers for more compact layout - Add instructions in main panel when no calculation done yet 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Standardize teal color across app to use TEAL_PRIMARY (#319795) - Updates all highlighted text, markers, and links for consistency - Matches Streamlit theme primaryColor - Reorder UI in target mode to show net income chart first - Calculate target donation before displaying any results - Use target donation as primary amount throughout all charts - Display "Your $X donation" based on target, not initial input - Remove initial donation marker from net income reduction chart - Only show the required donation marker for clarity - Simplifies chart and reduces visual clutter This creates a more logical flow where the target donation becomes the focus of all calculations and visualizations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
givecalc/Python package separating calculation logic from UIKey Changes
Package Structure
givecalc/package with clean APIui/directoryapp.pyremains in rootTesting (TDD)
make testoruv run pytest tests/Bug Fixes
tax_unitinstead ofhouseholdfor 2025)UI Improvements
st.form- no more reset after Calculate@st.cache_dataDeveloper Experience
Makefilefor common taskspyproject.toml(modern Python packaging)setup.pyCLAUDE.mddocumentationrequirements-dev.txtTest Results
All 33 tests passing. Performance: 1001 donation points calculated in ~1.3 seconds.
Fixes #32
🤖 Generated with Claude Code