-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix/item fixes #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/item fixes #1389
Conversation
|
A bit embarrassing that I didn't make sure it built first lol. Forgot to remove associated data with the duplicate items I removed! |
|
Alright, so we shouldn't have |
|
I know the apostrophe caused problems with the query, but the changes to é was mostly for consistency with other identifiers. I was definitely wary of bad responses with them, but I didn’t formally check that |
|
I'll wait for GH to fix the issue with Actions and then merge: https://www.githubstatus.com/ |
|
Of course, sounds good! |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
A lightweight PR to address the following issues:
koraidon’s-poké-ballandmiraidon’s-poké-ball#1387academy-bottle#1388This PR also replaced other instances of "é" used in identifiers for items with plain "e" and removed the other duplicate "acadaemy-___" items for the picnics in SV.