Add missing past ability information for Hisuian pokemon.

[jemarq04]

Added the missing information using Bulbapedia as a resource: https://bulbapedia.bulbagarden.net/wiki/List_of_modified_Ability_access#From_Generation_VIII_to_Generation_IX. Other pokemon listen in the "Generation VIII to Generation IX" section were added except the Hisuian pokemon/forms.

Additionally, the past ability entry for Gallade was removed to be consistent. No other pokemon that has gained a second possible ability has been listed in this file, so only listing Gallade was inconsistent.

(As a side note, I'd be interested in seeing pokemon who gained an ability to have such an entry, but I did not want to make this decision myself. If this sounds interesting, I am more than happy to make these changes.)

Aside from the additions (and one removal) listed above to a CSV file, no other changes were made to the repo.

[Naramsim]

(As a side note, I'd be interested in seeing pokemon who gained an ability to have such an entry, but I did not want to make this decision myself. If this sounds interesting, I am more than happy to make these changes.)

This seems quite a tedius job? The file we have might not be sufficient to handle this case, I think. Adding one more file or a new column added/removed might be necessary?

[jemarq04]

It's a bit tedious, but fortunately I enjoy tedious jobs like this. I actually started on a possible method last night, but I still need to double-check its accuracy and polish it (like removing duplicate entries from Bulbapedia for pokemon with multiple forms like Shellos, Jellicent).

One way to implement it would be to follow the entry for Gallade mentioned in my original comment - stating that the "past" ability that was overwritten was the ability in the first slot. This was the method I've been working on as a check. Essentially this would pretend Gallade's two abilities were Steadfast (first slot) and Steadfast (second slot), as an example.

Another option (which would be more readable, I think) is to leave the ability_id column blank if the past ability didn't exist, like in gen 4 when many pokemon gained a second ability. But this would require modifying other scripts to make a separate check for that. I'd be interested in this option, but I would need to look into the framework more to better understand how it can be implemented.

Sorry this was a bit wordy - I'm not quite sure where I should post these ideas for a wider sort of response on what is preferred by others so I thought I would put it here. I'm looking into both options to see how feasible they are.

[pokeapi-machine-user]

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

[pokeapi-machine-user]

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

[Naramsim]

It's a bit tedious, but fortunately I enjoy tedious jobs like this. I actually started on a possible method last night, but I still need to double-check its accuracy and polish it (like removing duplicate entries from Bulbapedia for pokemon with multiple forms like Shellos, Jellicent).

One way to implement it would be to follow the entry for Gallade mentioned in my original comment - stating that the "past" ability that was overwritten was the ability in the first slot. This was the method I've been working on as a check. Essentially this would pretend Gallade's two abilities were Steadfast (first slot) and Steadfast (second slot), as an example.

Another option (which would be more readable, I think) is to leave the ability_id column blank if the past ability didn't exist, like in gen 4 when many pokemon gained a second ability. But this would require modifying other scripts to make a separate check for that. I'd be interested in this option, but I would need to look into the framework more to better understand how it can be implemented.

Sorry this was a bit wordy - I'm not quite sure where I should post these ideas for a wider sort of response on what is preferred by others so I thought I would put it here. I'm looking into both options to see how feasible they are.

Hmm, ok, I need to read this part well. I also saw you opened a PR. It's gonna take me some time to review this decently. Sorry!

[jemarq04]

Hmm, ok, I need to read this part well. I also saw you opened a PR. It's gonna take me some time to review this decently. Sorry!
Of course, no rush! The PR that was made implements the second option I thought of, as it would be the easiest to understand when accessing the data.