-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
pokeapi/data/v2/csv/pokemon.csv
Lines 1304 to 1305 in 0bc1342
| 10278,frillish-female,592,12,330,67,,0 | |
| 10279,jellicent-female,593,22,1350,168,,0 |
Need to remove the last two lines from pokemon.csv. Frillish and Jellicent have gender differences for sprites, just like hundreds of others. This is already correctly indicated here:
pokeapi/data/v2/csv/pokemon_species.csv
Line 593 in 0bc1342
| 592,frillish,5,,301,9,10,,4,190,50,0,20,1,2,0,0,0,593, |
Issue was introduced in #1189 which added encounters, including a Jellicent encounter in encounters.csv here:
Looks like encounters.csv doesn't have a field for gender, nor any instance data e.g. ability. As a separate issue, maybe it should? At least for encounters with a slot corresponding to encounter method of "only one" i.e. static encounters?
That Jellicent is always female in White 2, and the encounter above it is a Jellicent that is always male in Black 2, but both also always have Damp for their ability too. If the dataset is going to include that level of specificity, there would probably need be another whole table for static encounter details like that. Otherwise, it should be taken out.
The better fix for now is just to not include gender (or ability, etc) details under the encounters. More importantly: remove non-existent "frillish-female" 10278 and "jellicent-female" 10279 in pokemon.csv. Also change the id in encounters.csv from jellicent-female (10279) to jellicent (593) like the one above it.