Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the rendering of some plots that failed silently #17

Merged
merged 8 commits into from
Jul 27, 2020

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Jul 24, 2020

@tpoisot tpoisot added the bug Something isn't working label Jul 24, 2020
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #17 into master will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   71.63%   71.90%   +0.27%     
==========================================
  Files           8        8              
  Lines         208      210       +2     
==========================================
+ Hits          149      151       +2     
  Misses         59       59              
Flag Coverage Δ
#unittests 71.90% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/forcedirected.jl 86.00% <100.00%> (+0.58%) ⬆️
src/recipes.jl 82.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6a11a...b628993. Read the comment docs.

@tpoisot
Copy link
Member Author

tpoisot commented Jul 24, 2020

The issue is in plots using Force Directed Layouts, so I need to debug these functions...

@tpoisot tpoisot merged commit 53608b8 into master Jul 27, 2020
@tpoisot tpoisot deleted the fix/plots-not-rendered branch November 21, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some example plots not rendering specify that users must also call using Plots
1 participant