Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake scripts in tutorials (remove superfluous include_directories et al. calls) #2607

Open
SergioRAgostinho opened this issue Nov 9, 2018 · 2 comments
Labels
good first issue Skills/areas of expertise needed to tackle the issue kind: todo Type of issue module: tutorials skill: cmake Skills/areas of expertise needed to tackle the issue

Comments

@SergioRAgostinho
Copy link
Member

I was thinking about the CMakeLists in tutorials, do they need to be updated as well? My conclusion was no, not yet. It should still be possible to use PCL in downstream projects with old CMake. But once we switch to C++14 we should consider bumping version there and requesting CXX_14 explicitly.

Originally posted by @taketwo in #2605 (comment)

@taketwo
Copy link
Member

taketwo commented Jan 19, 2019

CXX_14 is requested automatically through target compile options. What we may want to do at some point though is remove unnecessary:

include_directories(${PCL_INCLUDE_DIRS})
link_directories(${PCL_LIBRARY_DIRS}) 
add_definitions(${PCL_DEFINITIONS})

I'm hesitant to do it now because this will break compatibility with pre-1.9 versions. So someone who obtained an older PCL through agt-get and then looked up an (updated) tutorial on the website won't be able to successfully compile.

Edit: removing this from migration project.

@taketwo taketwo changed the title Update CMake min version in tutorials once C++14 flags are set Update CMake scripts in tutorials (remove superfluous include_directories et al. calls) Jan 19, 2019
@taketwo taketwo removed the c++14 label Jan 19, 2019
@stale
Copy link

stale bot commented May 19, 2020

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the status: stale label May 19, 2020
@kunaltyagi kunaltyagi added the kind: todo Type of issue label Jun 5, 2020
@stale stale bot removed the status: stale label Jun 5, 2020
@kunaltyagi kunaltyagi added good first issue Skills/areas of expertise needed to tackle the issue skill: cmake Skills/areas of expertise needed to tackle the issue labels Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Skills/areas of expertise needed to tackle the issue kind: todo Type of issue module: tutorials skill: cmake Skills/areas of expertise needed to tackle the issue
Projects
None yet
Development

No branches or pull requests

3 participants