Provide perspective token in JupyterLab to ensure proper ordering of other extensions#1
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
…nsion Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
d11cfe7 to
212f62a
Compare
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JupyterLab has a mechanism for having plugins depend on other plugins.
Since perspective registers custom elements (see perspective-dev#3056), this change lets other Jupyter extensions "depend" on
@finos/perspective-jupyterlabby doing:This then ensures that
@finos/perspective-jupyterlabgets activated beforeMyCoolPlugin, ensuring that custom webcomponents and wasm loading occurs. Downstream plugins likeMyCoolPlugincan then just do:without any additional initialization.
Fixes perspective-dev#3056
I'm open to adding tests but its just a constant, not sure what the best mechanism for doing so is.
We can also add developer docs if we want, happy to write them.donePull Request Checklist
Discussions, this PR applies to.