Correct adjustment of annotations on OutputBasket type. Fixes #483. #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomecek
requested review from
robambalu,
AdamGlustein,
svatasoiu and
alexddobkin
as code owners
AdamGlustein
requested changes
Mar 8, 2025
…revalidation of output basket types when an int type is present Signed-off-by: Pascal Tomecek <pascal.tomecek@cubistsystematic.com>
robambalu
approved these changes
Mar 9, 2025
|
@AdamGlustein Are you good with the latest changes? |
AdamGlustein
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483. Required for revalidation of output basket types when an int type is present.
The original adjustment of annotations converts
OutputBasketContainertoOutputBasket. So when re-validating theint-based outputs after type var resolution, it needs to be able to handle theOutputBaskettype, which it wasn't doing before. This PR fixes that issue, and also adds an explicit test forcsp.basketlib.syncfor a dict basket with int types, in addition to unit tests on the annotation adjustment.