-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ParquetReader to read LARGE_STRING, LARGE_BINARY, LARGE_LIST types from Arrow #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robambalu
reviewed
Feb 28, 2025
700b337
to
645ac2f
Compare
robambalu
reviewed
Mar 3, 2025
robambalu
reviewed
Mar 3, 2025
944f867
to
e8b3379
Compare
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
AdamGlustein
requested changes
Mar 4, 2025
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
e8b3379
to
42264b3
Compare
AdamGlustein
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but would appreciate if @timkpaine or @robambalu can take a final look as well, as they know the Arrow API better than myself.
robambalu
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
adapter: parquet
Issues and PRs related to our Apache Parquet/Arrow adapter
type: enhancement
Issues and PRs related to improvements to existing features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading
LARGE_STRING, LARGE_BINARY, LARGE_LIST
Arrow types in theParquetReader
Resolves #398
With this change, the
ParquetReader
can be used withArrow Large Types
especially inpolars
more seamlessly: