Increase leeway for test_alarm_leak, which uses more memory on GH Actions runs #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n GitHub Actions Signed-off-by: Adam Glustein <adam.glustein@point72.com>
AdamGlustein
requested review from
robambalu,
svatasoiu and
alexddobkin
as code owners
alexddobkin
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed this test failing sporadically on our scheduled builds, like: https://github.com/Point72/csp/actions/runs/13366028175/job/37327469976. Since the comment states the leak would increase RSS memory by at least 50 MB, we can increase leeway from 5 MB to 10 MB to reduce noise from this test (for example, it used 7.3 MB in the failed run above).