Allow pulling Kafka timestamp from message, allow skipping kafka data… #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeejWeej
requested review from
robambalu,
AdamGlustein,
svatasoiu and
alexddobkin
as code owners
… before start Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
NeejWeej
force-pushed
the
nk/kafka_pull_ts_from_msg
branch
from
a906515 to
11377fb
Compare
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
NeejWeej
force-pushed
the
nk/kafka_pull_ts_from_msg
branch
from
6156541 to
b6e0438
Compare
robambalu
requested changes
Feb 20, 2025
…d not on the struct Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
robambalu
approved these changes
Feb 20, 2025
timkpaine
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… before start
Add extract_timestamp_from_field option to Kafka subscriptions. We already deal with Kafka timestamps possibly being unordered by allowing adjust_out_of_order_time, and this is very helpful for replaying ticks from Kafka at the correct time historically
Add include_msg_before_start_time option to Kafka subscriptions to allow filtering out messages if they are before engine start time. The default is True, in which case, 'adjust_out_of_order_time' should be set to True.
This is would change behavior, in that if 'adjust_out_of_order_time' is False, this would crash. To avoid that, for backwards compatibility, if
adjust_out_of_order_timeis False, and we get a message that is before engine start time, we push live