Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ruff to 0.9, add ruff isort, normalize conda recipes, clean docs to only use makefile commands #329

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Bump ruff to 0.9, add ruff isort, normalize conda recipes, clean docs to only use makefile commands #329

merged 2 commits into from
Mar 4, 2025

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Jul 13, 2024 •
edited
Loading

  • Update our ruff dependency to 0.7
  • Use and apply ruff.isort rules
  • Normalize conda recipes to have same stuff, with comments
  • Clean up docs to avoid getting out of sync with makefile

closes #472

@timkpaine timkpaine added lang: python Issues and PRs related to the Python codebase part: dependencies PRs that update a dependency file tag: internal Issues and PRs for maintainance of the project - not interesting to external users labels Jul 13, 2024
@timkpaine timkpaine changed the title Bump ruff to 0.5, normalize conda recipes, clean docs to only use makefile commands Bump ruff to 0.5, add ruff isort, normalize conda recipes, clean docs to only use makefile commands Jul 13, 2024
@timkpaine timkpaine marked this pull request as ready for review July 13, 2024 18:18
@timkpaine timkpaine force-pushed the tkp/ruffclean branch 2 times, most recently from 1c0b3d2 to 1e0cb27 Compare August 9, 2024 23:14
@arhamchopra arhamchopra mentioned this pull request Aug 26, 2024
Merged
@timkpaine timkpaine changed the title Bump ruff to 0.5, add ruff isort, normalize conda recipes, clean docs to only use makefile commands Bump ruff to 0.7, add ruff isort, normalize conda recipes, clean docs to only use makefile commands Nov 5, 2024
@timkpaine timkpaine force-pushed the tkp/ruffclean branch 2 times, most recently from 4fc5fa0 to 9200800 Compare March 1, 2025 00:32
@timkpaine timkpaine changed the title Bump ruff to 0.7, add ruff isort, normalize conda recipes, clean docs to only use makefile commands Bump ruff to 0.9, add ruff isort, normalize conda recipes, clean docs to only use makefile commands Mar 1, 2025
@timkpaine timkpaine force-pushed the tkp/ruffclean branch 2 times, most recently from 02c5cb0 to 854ad8e Compare March 1, 2025 00:40
@timkpaine
Bump ruff to 0.9, normalize conda recipes, clean docs to only use mak…
3fe608f 
…efile commands

Add ruff isort to rules
apply isort
update settings

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine timkpaine mentioned this pull request Mar 4, 2025
Closed
@ptomecek
Copy link
Collaborator

ptomecek commented Mar 4, 2025

@robambalu @AdamGlustein Any concerns with this PR? It fixes someone else I was independently trying to fix in #472.

@AdamGlustein
Copy link
Collaborator

Fix conflicts and its good with me

@timkpaine timkpaine requested a review from AdamGlustein March 4, 2025 20:27
@timkpaine timkpaine merged commit a2ddfa0 into main Mar 4, 2025
28 checks passed
@timkpaine timkpaine deleted the tkp/ruffclean branch March 4, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robambalu robambalu robambalu left review comments

@AdamGlustein AdamGlustein AdamGlustein approved these changes

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

@ptomecek ptomecek Awaiting requested review from ptomecek ptomecek is a code owner

Assignees
No one assigned
Labels
lang: python Issues and PRs related to the Python codebase part: dependencies PRs that update a dependency file tag: internal Issues and PRs for maintainance of the project - not interesting to external users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timkpaine @ptomecek @AdamGlustein @robambalu