Improve ModelRegistry item assignment error - #254
Conversation
Signed-off-by: russlan23 <rrusslanjr@gmail.com>
Signed-off-by: russlan23 <rrusslanjr@gmail.com>
|
I refreshed this branch against current |
Might need to have codex swap newlines for actual newlines 😉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 93.47% 93.48%
=======================================
Files 176 176
Lines 20319 20327 +8
Branches 1350 1350
=======================================
+ Hits 18994 19002 +8
Misses 1052 1052
Partials 273 273 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Closes #162.
Adds an explicit
ModelRegistry.__setitem__error that directs users to the controlledaddAPI. The regression verifies the message and confirms that a failed assignment leaves the registry unchanged.Type of Change
Validation
python -m pytest -q ccflow/tests/test_base_registry.py- 43 passedpython -m ruff check ccflow/base.py ccflow/tests/test_base_registry.py- passedpython -m ruff format --check ccflow/base.py ccflow/tests/test_base_registry.py- passedgit diff --check- passedA clean full-suite attempt could not install the complete optional development extra because the package download timed out; the repository CI can provide the full declared matrix.
Checklist
make testpasses locally