Skip to content

Conversation

@ptomecek
Copy link
Collaborator

@ptomecek ptomecek commented Feb 3, 2026

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Test Results

633 tests  +88   629 ✅ +88   1m 39s ⏱️ ±0s
  1 suites ± 0     4 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit bbcd76c. ± Comparison against base commit 1345a67.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 97.95737% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.85%. Comparing base (1345a67) to head (bbcd76c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ccflow/ui/cli.py 61.53% 10 Missing ⚠️
ccflow/ui/model.py 95.45% 3 Missing and 2 partials ⚠️
ccflow/base.py 73.33% 4 Missing ⚠️
ccflow/tests/ui/utils.py 81.25% 2 Missing and 1 partial ⚠️
ccflow/tests/ui/test_model.py 99.68% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   95.50%   95.85%   +0.34%     
==========================================
  Files         132      140       +8     
  Lines        8463     9582    +1119     
  Branches      521      551      +30     
==========================================
+ Hits         8083     9185    +1102     
- Misses        262      278      +16     
- Partials      118      119       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptomecek ptomecek marked this pull request as ready for review February 3, 2026 21:46
@ptomecek ptomecek force-pushed the pit/ui branch 2 times, most recently from 42db252 to 4f51b1e Compare February 4, 2026 00:02
Signed-off-by: Pascal Tomecek <pascal.tomecek@cubistsystematic.com>
Signed-off-by: Pascal Tomecek <pascal.tomecek@cubistsystematic.com>
@feussy feussy self-requested a review February 4, 2026 22:24
feussy
feussy previously approved these changes Feb 4, 2026
Copy link
Member

@timkpaine timkpaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of overlap with

def get_args_parser_default() -> argparse.ArgumentParser:
, should we move the UI stuff from that here? maybe share some of the CLI builders?

@ptomecek
Copy link
Collaborator Author

ptomecek commented Feb 5, 2026

There's a lot of overlap with

def get_args_parser_default() -> argparse.ArgumentParser:

, should we move the UI stuff from that here? maybe share some of the CLI builders?

Yeah, I noticed that. I think the definition of the args for launching a panel app should be re-used between places, but not sure there is too much else. I'll take a closer look at it.

Signed-off-by: Pascal Tomecek <pascal.tomecek@cubistsystematic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants