-
Notifications
You must be signed in to change notification settings - Fork 5
Add first cut of panel ui components for viewing the registry and models #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
+ Coverage 95.50% 95.85% +0.34%
==========================================
Files 132 140 +8
Lines 8463 9582 +1119
Branches 521 551 +30
==========================================
+ Hits 8083 9185 +1102
- Misses 262 278 +16
- Partials 118 119 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
42db252 to
4f51b1e
Compare
Signed-off-by: Pascal Tomecek <pascal.tomecek@cubistsystematic.com>
Signed-off-by: Pascal Tomecek <pascal.tomecek@cubistsystematic.com>
timkpaine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of overlap with
Line 240 in 0d02a00
| def get_args_parser_default() -> argparse.ArgumentParser: |
Yeah, I noticed that. I think the definition of the args for launching a panel app should be re-used between places, but not sure there is too much else. I'll take a closer look at it. |
Signed-off-by: Pascal Tomecek <pascal.tomecek@cubistsystematic.com>
No description provided.