Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
copper_idsfrom enabled layers and then sorted them, which could placeB.Cunot at the last index and cause incorrect top/bottom mapping and physics at outer faces.Description
GetLayerStackup/GetStackupand iteratingGetCopperLayers/GetLayerSequence/GetLayerswhen available to preserve real stack order.add_uniquehelper to de-duplicate layer IDs while preserving discovered order and ensure layers areenabledandpcbnew.IsCopperLayerbefore inclusion.GetCopperLayerCountand constants likepcbnew.F_Cu,pcbnew.In1_Cu,pcbnew.B_Cu, and finally a legacy numeric scan over layer IDs for older KiCad versions.layer_namesfrom the final orderedcopper_idsso plotting and top/bottom references are correct.Testing
Codex Task