Board 001. create board component #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 8, 2022 11:34
Kate4ka007
reviewed
Nov 8, 2022
| @@ -0,0 +1,5 @@ | |||
| .board{ | |||
1LisaW
reviewed
Nov 8, 2022
| <small class="notification" *ngIf="validateForm.get('nickname')?.errors?.['required'] && validateForm.get('nickname')?.touched"> | ||
| {{'AUTH.REQUIRED_NAME' | translate}} | ||
| </small> | ||
| <small class="notification" *ngIf="validateForm.get('nickname')?.getError('minlength')">{{'AUTH.MINLENGTH_NAME' | translate}}</small> |
Contributor
There was a problem hiding this comment.
'minlength' will be better reading with camelCase 'minLength'
Kate4ka007
reviewed
Nov 8, 2022
| <a routerLink="/workspace/boards">{{'WORKSPACE.CREATE_BOARD' | translate}}</a> | ||
| <div> | ||
| <a routerLink="/workspace/boards"> | ||
| <h2>NAME</h2> |
Kate4ka007
reviewed
Nov 8, 2022
| @@ -1,0 +1,14 @@ | |||
| h1{ | |||
Kate4ka007
reviewed
Nov 8, 2022
| align-items: center; | ||
| } | ||
|
|
||
| .boards{ |
1LisaW
reviewed
Nov 8, 2022
| <a routerLink="/workspace/boards"> | ||
| <h2>NAME</h2> | ||
| </a> | ||
| <button (click)="deleteBoard()">DELETE</button> |
1LisaW
reviewed
Nov 8, 2022
| <a routerLink="/workspace/boards">{{'WORKSPACE.CREATE_BOARD' | translate}}</a> | ||
| <div> | ||
| <a routerLink="/workspace/boards"> | ||
| <h2>NAME</h2> |
Contributor
There was a problem hiding this comment.
Name should be translated depandes on language
Kate4ka007
approved these changes
Nov 8, 2022
1LisaW
approved these changes
Nov 8, 2022
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.