Program renaming feature #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-praline-605cf6 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Molaryy
added this to the Sprint 2 - Aleph skills development & first project contribution milestone
…ng to delete a program
RezaRahemtola
requested changes
May 11, 2023
|
|
||
| const ProgramOptionsContent = ({ program }: { program: IPCProgram }): JSX.Element => ( | ||
| const ProgramOptionsContent = ({ program }: { program: IPCProgram}): JSX.Element => ( |
There was a problem hiding this comment.
looks like it's still not properly linted 👀
| try { | ||
| if (this.account) { | ||
| await forget.Publish({ | ||
| const test = await forget.Publish({ |
There was a problem hiding this comment.
Suggested change
| const test = await forget.Publish({ | |
| await forget.Publish({ |
| @@ -53,16 +54,15 @@ class Computing { | |||
| } | |||
| } | |||
|
|
|||
| public async deleteProgram(programHash: string): Promise<ResponseType> { | |||
| public async UpdateDeleteProgram(programHash: string): Promise<ResponseType> { | |||
There was a problem hiding this comment.
Suggested change
| public async UpdateDeleteProgram(programHash: string): Promise<ResponseType> { | |
| public async deleteProgram(programHash: string): Promise<ResponseType> { |
This function is only deleting a program, not updating it ?
Comment on lines
+80
to
+87
| const copy = concernedProgram; | ||
| await Promise.all( | ||
| this.programs.map(async () => { | ||
| copy.name = newName; | ||
| copy.log.push({ | ||
| action: `Renamed program to ${newName}`, | ||
| date: Date.now(), | ||
| }); |
There was a problem hiding this comment.
I don't think this will work 🤔
Maybe something like this:
Suggested change
| const copy = concernedProgram; | |
| await Promise.all( | |
| this.programs.map(async () => { | |
| copy.name = newName; | |
| copy.log.push({ | |
| action: `Renamed program to ${newName}`, | |
| date: Date.now(), | |
| }); | |
| await Promise.all( | |
| this.programs = this.programs.map(async (prog) => { | |
| if (prog.id === concernedProgram.id) { | |
| const newLog = { | |
| action: `Renamed program to ${newName}`, | |
| date: Date.now(), | |
| }; | |
| return {...prog, name: newName, logs: [...prog.logs, newLog]} | |
| } | |
| return prog; |
There was a problem hiding this comment.
btw you can remove the async and Promise.all here, nothing is awaited
| @@ -82,20 +105,18 @@ class Computing { | |||
| if (this.account) { | |||
| // remove old program from user's programs array | |||
| if (isRedeploy && oldProgramHash) { | |||
| const newProgramsArray: IPCProgram[] = this.programs.filter( | |||
| const newProgramsArray: IPCProgram[] = this.programs.filter ( | |||
There was a problem hiding this comment.
Suggested change
| const newProgramsArray: IPCProgram[] = this.programs.filter ( | |
| const newProgramsArray: IPCProgram[] = this.programs.filter( |
| @@ -7,11 +7,12 @@ import fileDownload from 'js-file-download'; | |||
|
|
|||
| import { ALEPH_CHANNEL } from 'config/constants'; | |||
|
|
|||
| import type { AggregateType, IPCContact, IPCFile, IPCFolder, ResponseType, UploadResponse } from 'types/types'; | |||
| import type { AggregateType, IPCContact, IPCFile, IPCFolder, ResponseType, UploadResponse} from 'types/types'; | |||
There was a problem hiding this comment.
Suggested change
| import type { AggregateType, IPCContact, IPCFile, IPCFolder, ResponseType, UploadResponse} from 'types/types'; | |
| import type { AggregateType, IPCContact, IPCFile, IPCFolder, ResponseType, UploadResponse } from 'types/types'; |
linting again
Comment on lines
+21
to
29
| export type ProgramLog = { | ||
| action: string; | ||
| date: number; | ||
| }; | ||
|
|
||
| export type FileLog = { | ||
| action: string; | ||
| date: number; | ||
| }; |
There was a problem hiding this comment.
These are literally the same type, you can just use a single type Log it will be cleaner
| hash: string; | ||
| name: string; | ||
| createdAt: number; | ||
| entrypoint: string; | ||
| size: number; | ||
| log: ProgramLog[]; |
There was a problem hiding this comment.
Suggested change
| log: ProgramLog[]; | |
| logs: ProgramLog[]; |
An array of log, adding an s looks better
| const textColor = useColorModeValue(textColorMode.light, textColorMode.dark); | ||
| const { colorMode } = useColorMode(); | ||
|
|
||
| const DeleteActualProgram = async () => { |
There was a problem hiding this comment.
Suggested change
| const DeleteActualProgram = async () => { | |
| const deleteActualProgram = async () => { |
Use PascalCase only for component names, not for functions 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the fronted for the program rename and also the backend.
Changes include
Checklist