fix: handling error on route backend #241
Open
+56
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add decorator to handle Integrity Error or other error on process CRUD - Add decorator on delete route for organisms and users Reviewed-by: andriac
andriacap
force-pushed
the
fix/handling-error-route-backend
branch
from
d321c48 to
290d671
Compare
jacquesfize
reviewed
May 21, 2025
Contributor
There was a problem hiding this comment.
L'idée est bonne ! Toutefois, je pense que la déclaration du décorateurs sur les routes concernées n'est pas idéal. Je pense qu'il est plus simple de s'appuyer sur la mécanique Flask des error_handlers https://flask.palletsprojects.com/en/stable/errorhandling/.
L'idée serait d'appeller une fonction à chaque erreur 500. Dans cette fonction, si l'erreur est une erreur SQLA, on affiche le message d'erreur (dans un flash).
app/t_roles/route.py
Outdated
| 6, | ||
| ) | ||
| @fnauth.check_auth(6) | ||
| @handle_db_errors("user.users", "l'utilisateur", redirect_on_error=True) |
Contributor
There was a problem hiding this comment.
Lourd si on doit déclarer ça plusieurs fois ...
Author
There was a problem hiding this comment.
J'ai proposé une solution centralisée en terme de gestion d'erreurs
andriacap
force-pushed
the
fix/handling-error-route-backend
branch
from
ab37e68 to
fc80d3e
Compare
- Add handler function according to current function existing in errors.py Reviewed-by: andriac
andriacap
force-pushed
the
fix/handling-error-route-backend
branch
from
fc80d3e to
b36db95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when error happened
After with handle error
Reviewed-by: andriacap